devsam/core
3
6
Fork 1
Code Issues 60 Pull Requests Releases 1 Wiki Activity

fix: phan 지시에 따라 일부 버그 수정

Browse Source 
- null && key_exists 버그
- or assign이 integer 대상이므로 직접 연산
- false 대신 0 입력한 곳 수정
- 자체 Deprecate 처리한 함수 회피
- 초기화되지 않은 [] 확인하여 처리
- sleep은 정수만 받으므로 usleep으로 변경
- 선언하지 않고 그냥 사용하던 member 변수 선언
- boolean operation 순서 틀린 부분 수정
This commit is contained in:
Hide_D
2021-08-12 23:58:20 +09:00
parent 0975e925a9
commit ee8854451c
67 changed files with 51 additions and 137 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hwe/sammo/Command/BaseCommand.php
+2
View File
@@ -18,6 +18,7 @@ abstract class BaseCommand{
static protected $actionName = 'CommandName';
static public $reqArg = false;
static protected $isLazyCalcReqTurn = false;
public ?string $reason;
public function getCommandDetailTitle():string{
return $this->getName();
@@ -48,6 +49,7 @@ abstract class BaseCommand{
protected $fullConditionConstraints = null;
protected $minConditionConstraints = null;
protected $permissionConstraints = null;
protected $reasonConstraint = null;
protected $logger;
hwe/sammo/Command/General/che_강행.php
-2
View File
@@ -12,8 +12,6 @@ use \sammo\GameUnitConst;
use \sammo\LastTurn;
use \sammo\Command;
use function \sammo\tryUniqueItemLottery;
use function \sammo\printCitiesBasedOnDistance;
use \sammo\Constraint\Constraint;
hwe/sammo/Command/General/che_거병.php
-2
View File
@@ -14,9 +14,7 @@ use \sammo\{
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
use sammo\CityConst;
use function sammo\buildNationTypeClass;
use function sammo\refreshNationStaticInfo;
use function sammo\GetNationColors;
use function sammo\getAllNationStaticInfo;
hwe/sammo/Command/General/che_견문.php
-3
View File
@@ -10,9 +10,6 @@ use \sammo\{
Command
};
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
use \sammo\TextDecoration\SightseeingMessage;
hwe/sammo/Command/General/che_군량매매.php
-2
View File
@@ -12,8 +12,6 @@ use \sammo\{
Command
};
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
use sammo\MustNotBeReachedException;
hwe/sammo/Command/General/che_귀환.php
-3
View File
@@ -10,9 +10,6 @@ use \sammo\{
Command
};
use function \sammo\getNationStaticInfo;
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
use sammo\CityConst;
hwe/sammo/Command/General/che_기술연구.php
-1
View File
@@ -11,7 +11,6 @@ use \sammo\{
use function sammo\{
TechLimit,
getDomesticExpLevelBonus,
CriticalRatioDomestic,
CriticalScoreEx,
tryUniqueItemLottery,
hwe/sammo/Command/General/che_내정특기초기화.php
-3
View File
@@ -10,9 +10,6 @@ use \sammo\{
Command
};
use function \sammo\getNationStaticInfo;
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/General/che_단련.php
-1
View File
@@ -11,7 +11,6 @@ use \sammo\{
};
use function \sammo\getNationStaticInfo;
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
hwe/sammo/Command/General/che_랜덤임관.php
-2
View File
@@ -15,8 +15,6 @@ use \sammo\LastTurn;
use \sammo\Command;
use function \sammo\tryUniqueItemLottery;
use function \sammo\getInvitationList;
use function \sammo\getNationStaticInfo;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/General/che_숙련전환.php
-2
View File
@@ -16,9 +16,7 @@ use \sammo\Command;
use \sammo\ServConfig;
use function \sammo\getDexCall;
use function \sammo\getTechCall;
use function \sammo\tryUniqueItemLottery;
use function \sammo\getTechAbil;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/General/che_이동.php
-1
View File
@@ -12,7 +12,6 @@ use \sammo\GameUnitConst;
use \sammo\LastTurn;
use \sammo\Command;
use function \sammo\tryUniqueItemLottery;
use function \sammo\printCitiesBasedOnDistance;
use \sammo\Constraint\Constraint;
hwe/sammo/Command/General/che_인재탐색.php
-4
View File
@@ -12,11 +12,7 @@ use \sammo\LastTurn;
use \sammo\GameUnitConst;
use \sammo\Command;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\tryUniqueItemLottery;
use function \sammo\getAllNationStaticInfo;
use function \sammo\pickGeneralFromPool;
use \sammo\Constraint\Constraint;
hwe/sammo/Command/General/che_증여.php
-5
View File
@@ -13,11 +13,6 @@ use \sammo\LastTurn;
use \sammo\GameUnitConst;
use \sammo\Command;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/General/che_첩보.php
-1
View File
@@ -13,7 +13,6 @@ use \sammo\LastTurn;
use \sammo\Command;
use \sammo\Json;
use function \sammo\tryUniqueItemLottery;
use function \sammo\searchDistance;
use function \sammo\printCitiesBasedOnDistance;
hwe/sammo/Command/General/che_해산.php
-3
View File
@@ -14,10 +14,7 @@ use \sammo\{
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
use sammo\CityConst;
use function sammo\buildNationTypeClass;
use function sammo\refreshNationStaticInfo;
use function sammo\GetNationColors;
use function sammo\getAllNationStaticInfo;
use function sammo\deleteNation;
hwe/sammo/Command/General/che_헌납.php
-5
View File
@@ -12,11 +12,6 @@ use \sammo\LastTurn;
use \sammo\GameUnitConst;
use \sammo\Command;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_국기변경.php
-5
View File
@@ -17,11 +17,6 @@ use \sammo\Message;
use \sammo\CityConst;
use \sammo\Json;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\GetImageURL;
use function \sammo\getNationStaticInfo;
use function \sammo\GetNationColors;
use function \sammo\newColor;
hwe/sammo/Command/Nation/che_국호변경.php
-6
View File
@@ -17,12 +17,6 @@ use \sammo\MessageTarget;
use \sammo\Message;
use \sammo\CityConst;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\GetImageURL;
use function \sammo\getNationStaticInfo;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
use sammo\Event\Action;
hwe/sammo/Command/Nation/che_급습.php
-4
View File
@@ -15,12 +15,8 @@ use \sammo\Command;
use \sammo\Message;
use \sammo\MessageTarget;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\getNationStaticInfo;
use function \sammo\GetImageURL;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_몰수.php
-3
View File
@@ -15,9 +15,6 @@ use \sammo\Command;
use \sammo\MessageTarget;
use \sammo\Message;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\GetImageURL;
use \sammo\Constraint\Constraint;
hwe/sammo/Command/Nation/che_물자원조.php
-3
View File
@@ -14,9 +14,6 @@ use \sammo\{
StringUtil
};
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\getNationStaticInfo;
hwe/sammo/Command/Nation/che_불가침수락.php
-5
View File
@@ -16,12 +16,7 @@ use \sammo\MessageTarget;
use \sammo\DiplomaticMessage;
use \sammo\Message;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\getNationStaticInfo;
use function \sammo\GetImageUR;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_불가침제의.php
-3
View File
@@ -16,9 +16,6 @@ use \sammo\MessageTarget;
use \sammo\DiplomaticMessage;
use \sammo\Message;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\GetImageURL;
use function \sammo\getNationStaticInfo;
hwe/sammo/Command/Nation/che_불가침파기수락.php
-5
View File
@@ -16,12 +16,7 @@ use \sammo\MessageTarget;
use \sammo\DiplomaticMessage;
use \sammo\Message;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\getNationStaticInfo;
use function \sammo\GetImageURL;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_선전포고.php
-3
View File
@@ -15,9 +15,6 @@ use \sammo\Command;
use \sammo\Message;
use \sammo\MessageTarget;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\getNationStaticInfo;
use function \sammo\GetImageURL;
hwe/sammo/Command/Nation/che_의병모집.php
-5
View File
@@ -13,11 +13,6 @@ use \sammo\GameUnitConst;
use \sammo\Command;
use \sammo\KVStorage;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\tryUniqueItemLottery;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_이호경식.php
-4
View File
@@ -15,12 +15,8 @@ use \sammo\Command;
use \sammo\Message;
use \sammo\MessageTarget;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\getNationStaticInfo;
use function \sammo\GetImageURL;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_종전수락.php
-5
View File
@@ -18,12 +18,7 @@ use \sammo\{
Message,
};
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\getAllNationStaticInfo;
use function \sammo\getNationStaticInfo;
use function \sammo\GetImageURL;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_천도.php
-7
View File
@@ -15,13 +15,6 @@ use \sammo\Command;
use \sammo\MessageTarget;
use \sammo\Message;
use \sammo\CityConst;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\GetImageURL;
use function \sammo\getNationStaticInfo;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
use sammo\Event\Action;
hwe/sammo/Command/Nation/che_포상.php
-4
View File
@@ -13,10 +13,6 @@ use \sammo\LastTurn;
use \sammo\GameUnitConst;
use \sammo\Command;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use \sammo\Constraint\Constraint;
use \sammo\Constraint\ConstraintHelper;
hwe/sammo/Command/Nation/che_허보.php
-4
View File
@@ -16,10 +16,6 @@ use \sammo\MessageTarget;
use \sammo\Message;
use \sammo\CityConst;
use function \sammo\getDomesticExpLevelBonus;
use function \sammo\CriticalRatioDomestic;
use function \sammo\CriticalScoreEx;
use function \sammo\GetImageURL;
use function \sammo\getNationStaticInfo;
use \sammo\Constraint\Constraint;