refac: General 생성 방식 변경

- 변경한 GeneralQueryMode에 따라 Lite가 불가능
- Lite여도 된다면 GeneralLite 클래스로 변경
- 그렇지 않다면 General 클래스로 변경
- 내부에서 어떠한 연산을 할 지 알 수 없는데,
  구현 시점에서 편의에 따라 column 여부가 차이나면
  이후에 문제가 될 수 있음
- 엔진이 살짝 무거워 질 것으로 보임

hwe/sammo/API/Auction/GetUniqueItemAuctionDetail.php

@@ -77,7 +77,7 @@ class GetUniqueItemAuctionDetail extends \sammo\BaseAPI
     $inheritMgr = InheritancePointManager::getInstance();
     //preveious라서 column을 최대한 비울 수 있다.
     $remainPoint = $inheritMgr->getInheritancePoint(
-      General::createObjFromDB($generalID, ['owner'], GeneralQueryMode::Core),
+      General::createObjFromDB($generalID),
       InheritanceKey::previous
     );
 

hwe/sammo/API/Nation/GeneralList.php

@@ -5,8 +5,10 @@ namespace sammo\API\Nation;
 use ArrayObject;
 use sammo\DB;
 use sammo\Enums\APIRecoveryType;
+use sammo\Enums\GeneralLiteQueryMode;
 use sammo\Enums\GeneralQueryMode;
 use sammo\General;
+use sammo\GeneralLite;
 use sammo\Session;
 use sammo\Util;
 
@@ -165,7 +167,7 @@ class GeneralList extends \sammo\BaseAPI
 
 
 
-        [$queryColumns, $rankColumns, $accessLogColumns] = General::mergeQueryColumn(array_keys(static::$viewColumns), GeneralQueryMode::Lite);
+        [$queryColumns, $rankColumns, $accessLogColumns] = GeneralLite::mergeQueryColumn(array_keys(static::$viewColumns), GeneralLiteQueryMode::Lite);
 
         $rawGeneralList = Util::convertArrayToDict(
             $db->query(

hwe/sammo/API/Nation/GetNationInfo.php

@@ -58,7 +58,7 @@ class GetNationInfo extends \sammo\BaseAPI
       ];
     }
 
-    $generalObj = General::createObjFromDB($session->generalID, null, GeneralQueryMode::FullWithoutIAction);
+    $generalObj = General::createObjFromDB($session->generalID);
 
     $gameStor = KVStorage::getStorage($db, 'game_env');
     $gameEnv = $gameStor->getValues(['year', 'month', 'startyear']);

hwe/sammo/API/NationCommand/GetReservedCommand.php

@@ -113,7 +113,7 @@ class GetReservedCommand extends \sammo\BaseAPI
             ];
         }
 
-        $generalObj = General::createObjFromDB($session->generalID, null, GeneralQueryMode::FullWithoutIAction);
+        $generalObj = General::createObjFromDB($session->generalID);
 
 
         return [

hwe/sammo/API/Vote/AddComment.php

@@ -6,8 +6,10 @@ use DateTimeInterface;
 use sammo\DB;
 use sammo\DTO\VoteComment;
 use sammo\Enums\APIRecoveryType;
+use sammo\Enums\GeneralLiteQueryMode;
 use sammo\Enums\GeneralQueryMode;
 use sammo\General;
+use sammo\GeneralLite;
 use sammo\Session;
 use sammo\TimeUtil;
 use sammo\Validator;
@@ -41,7 +43,7 @@ class AddComment extends \sammo\BaseAPI
     $text = mb_substr($this->args['text'], 0, 200);
 
     $generalID = $session->generalID;
-    $general = General::createObjFromDB($generalID, null, GeneralQueryMode::Core);
+    $general = GeneralLite::createObjFromDB($generalID, null, GeneralLiteQueryMode::Core);
     $generalName = $general->getName();
     $nationID = $general->getNationID();
     $nationName = $general->getStaticNation()['name'];