[php5_debug] 접속중 정보를 업데이트 할 때 초기화 안한 변수, 건국국가가 없을 때 발생하는 워닝, empty array에 대한 foreach 등의 로직을 개선.

This commit is contained in:
2018-01-17 14:01:00 +09:00
parent f2113d235b
commit 16858743a7
+18 -12
View File
@@ -3979,23 +3979,29 @@ function updateOnline($connect) {
$result = MYDB_query($query, $connect) or Error(__LINE__.MYDB_error($connect),"");
$onlinenum = MYDB_num_rows($result);
$onnation = array();
$onnationstr = "";
//국가별 접속중인 장수
for($i=0; $i < $onlinenum; $i++) {
$general = MYDB_fetch_array($result);
$onnation[$general['nation']] .= $general['name'].', ';
}
foreach($onnation as $key => $val) {
$onnationstr .= "{$nationname[$key]}】, ";
if($key == 0) {
$query = "update game set onlinegen='$onnation[0]' where no='1'";
MYDB_query($query, $connect) or Error(__LINE__.MYDB_error($connect),"");
} else {
$query = "update nation set onlinegen='$onnation[$key]' where nation='$key'";
MYDB_query($query, $connect) or Error(__LINE__.MYDB_error($connect),"");
}
}
//$onnation이 empty라면 굳이 foreach를 수행 할 이유가 없음.
if(!empty($onnation)){
foreach($onnation as $key => $val) {
$onnationstr .= "{$nationname[$key]}】, ";
if($key == 0) {
$query = "update game set onlinegen='$onnation[0]' where no='1'";
MYDB_query($query, $connect) or Error(__LINE__.MYDB_error($connect),"");
} else {
$query = "update nation set onlinegen='$onnation[$key]' where nation='$key'";
MYDB_query($query, $connect) or Error(__LINE__.MYDB_error($connect),"");
}
}
}
//접속중인 국가
$query = "update game set online='$onlinenum',onlinenation='$onnationstr' where no='1'";