fix: preserve best-general rank data parity

packages/common/src/ranking/types.ts

@@ -47,6 +47,71 @@ export const RANK_DATA_TYPES = [
 
 export type RankDataType = (typeof RANK_DATA_TYPES)[number];
 
+/**
+ * Legacy `sammo\Enums\RankColumn` values stored in `rank_data`.
+ *
+ * `experience`, `dedication`, and `dex1` through `dex5` are natural general
+ * columns in the reference implementation. core2026 currently keeps mirrored
+ * rank rows for those values as a compatibility cache, but differential
+ * snapshots must compare this legacy set rather than treating the mirrors as
+ * source-of-truth rows.
+ */
+export const LEGACY_RANK_DATA_TYPES = [
+    'firenum',
+    'warnum',
+    'killnum',
+    'deathnum',
+    'killcrew',
+    'deathcrew',
+    'ttw',
+    'ttd',
+    'ttl',
+    'ttg',
+    'ttp',
+    'tlw',
+    'tld',
+    'tll',
+    'tlg',
+    'tlp',
+    'tsw',
+    'tsd',
+    'tsl',
+    'tsg',
+    'tsp',
+    'tiw',
+    'tid',
+    'til',
+    'tig',
+    'tip',
+    'betwin',
+    'betgold',
+    'betwingold',
+    'killcrew_person',
+    'deathcrew_person',
+    'occupied',
+    'inherit_earned',
+    'inherit_spent',
+    'inherit_earned_dyn',
+    'inherit_earned_act',
+    'inherit_spent_dyn',
+] as const satisfies readonly RankDataType[];
+
+export type LegacyRankDataType = (typeof LEGACY_RANK_DATA_TYPES)[number];
+
+const PREFIXED_RANK_DATA_TYPES = new Set<RankDataType>([
+    'warnum',
+    'killnum',
+    'deathnum',
+    'occupied',
+    'killcrew',
+    'deathcrew',
+    'killcrew_person',
+    'deathcrew_person',
+]);
+
+export const rankDataMetaKey = (type: RankDataType): string =>
+    PREFIXED_RANK_DATA_TYPES.has(type) ? `rank_${type}` : type;
+
 export const HALL_OF_FAME_TYPES = [
     'experience',
     'dedication',

packages/logic/src/actions/turn/general/che_은퇴.ts

@@ -14,7 +14,7 @@ import type { TurnCommandEnv } from '@sammo-ts/logic/actions/turn/commandEnv.js'
 import { defaultActionContextBuilder } from '@sammo-ts/logic/actions/turn/actionContext.js';
 import { tryApplyUniqueLottery } from '@sammo-ts/logic/rewards/uniqueLottery.js';
 import type { GeneralTurnCommandSpec } from './index.js';
-import { JosaUtil } from '@sammo-ts/common';
+import { JosaUtil, LEGACY_RANK_DATA_TYPES, rankDataMetaKey } from '@sammo-ts/common';
 
 export interface RetireArgs {}
 
@@ -22,7 +22,6 @@ const ACTION_NAME = '은퇴';
 const ACTION_KEY = 'che_은퇴';
 
 const REQ_AGE = 60;
-
 const reqGeneralValue = (): Constraint => ({
     name: 'reqGeneralValue',
     requires: (ctx) => [{ kind: 'general', id: ctx.actorId }],
@@ -51,46 +50,8 @@ export class ActionResolver<
         }
         nextMeta.specAge = 0;
         nextMeta.specAge2 = 0;
-        nextMeta.firenum = 0;
-        for (const key of [
-            'warnum',
-            'killnum',
-            'deathnum',
-            'killcrew',
-            'deathcrew',
-            'ttw',
-            'ttd',
-            'ttl',
-            'ttg',
-            'ttp',
-            'tlw',
-            'tld',
-            'tll',
-            'tlg',
-            'tlp',
-            'tsw',
-            'tsd',
-            'tsl',
-            'tsg',
-            'tsp',
-            'tiw',
-            'tid',
-            'til',
-            'tig',
-            'tip',
-            'betwin',
-            'betgold',
-            'betwingold',
-            'killcrew_person',
-            'deathcrew_person',
-            'occupied',
-            'inherit_earned',
-            'inherit_spent',
-            'inherit_earned_dyn',
-            'inherit_earned_act',
-            'inherit_spent_dyn',
-        ]) {
-            nextMeta[`rank_${key}`] = 0;
+        for (const type of LEGACY_RANK_DATA_TYPES) {
+            nextMeta[rankDataMetaKey(type)] = 0;
         }
 
         const josaYi = JosaUtil.pick(general.name, '이');