fix(gateway): purify global notice HTML

This commit is contained in:
2026-07-31 16:47:26 +00:00
parent 1168813eb3
commit 864cbfc0d0
10 changed files with 299 additions and 8 deletions
+6 -4
View File
@@ -12,6 +12,7 @@ import { toPublicUser } from './auth/userRepository.js';
import type { AdminAuthContext } from './adminAuth.js';
import type { GatewayApiContext } from './context.js';
import { GATEWAY_BUILD_STATUSES, GATEWAY_PROFILE_STATUSES } from './orchestrator/profileRepository.js';
import { purifyGatewayNoticeHtml } from './security/gatewayNoticeHtml.js';
const zProfileStatus = z.enum(GATEWAY_PROFILE_STATUSES);
const zBuildStatus = z.enum(GATEWAY_BUILD_STATUSES);
@@ -399,7 +400,7 @@ export const adminRouter = router({
const setting = await ctx.prisma.systemSetting.findUnique({
where: { id: 1 },
});
return { notice: setting?.notice ?? '' };
return { notice: purifyGatewayNoticeHtml(setting?.notice) };
}),
setNotice: noticeAdminProcedure
.input(
@@ -408,17 +409,18 @@ export const adminRouter = router({
})
)
.mutation(async ({ ctx, input }) => {
const notice = purifyGatewayNoticeHtml(input.notice);
const setting = await ctx.prisma.systemSetting.upsert({
where: { id: 1 },
create: {
id: 1,
notice: input.notice,
notice,
},
update: {
notice: input.notice,
notice,
},
});
return { notice: setting.notice };
return { notice: purifyGatewayNoticeHtml(setting.notice) };
}),
}),
users: router({
+2 -1
View File
@@ -15,6 +15,7 @@ import { accountRouter } from './account/router.js';
import { resolveLocalAccountProfilePolicy } from './auth/localAccountPolicy.js';
import { openPassword, zDisplayName, zPasswordEnvelope, zRegistrationUsername } from './auth/registrationInput.js';
import { resolveEffectiveAccountIcon } from './auth/accountIconProjection.js';
import { purifyGatewayNoticeHtml } from './security/gatewayNoticeHtml.js';
const zUsername = z
.string()
@@ -51,7 +52,7 @@ export const appRouter = router({
const setting = await ctx.prisma.systemSetting.findUnique({
where: { id: 1 },
});
return setting?.notice ?? '';
return purifyGatewayNoticeHtml(setting?.notice);
}),
profiles: procedure
.input(
@@ -0,0 +1,66 @@
import sanitizeHtml from 'sanitize-html';
const safeNamedColor =
/^(?:black|silver|gray|white|maroon|red|purple|fuchsia|green|lime|olive|yellow|navy|blue|teal|aqua|orange|cyan|magenta|skyblue|orangered|limegreen|darkorange)$/i;
const safeFontColor = (value: string): boolean => /^#[0-9a-f]{3,8}$/i.test(value) || safeNamedColor.test(value);
const safeFontFace = /^[\p{L}\p{N}\s,'".-]+$/u;
const options: sanitizeHtml.IOptions = {
allowedTags: ['br', 'b', 'strong', 'em', 'i', 'u', 's', 'strike', 'small', 'sup', 'sub', 'span', 'a', 'font'],
allowedAttributes: {
'*': ['style', 'title'],
a: ['href', 'target', 'rel', 'title', 'style'],
font: ['color', 'size', 'face', 'style', 'title'],
},
allowedSchemes: ['http', 'https', 'mailto', 'tel'],
allowProtocolRelative: false,
allowedStyles: {
'*': {
color: [/^#[0-9a-f]{3,8}$/i, /^rgba?\([\d\s.,%]+\)$/i, safeNamedColor],
'font-size': [
/^\d+(?:\.\d+)?(?:px|pt|em|rem|%)$/i,
/^(?:xx-small|x-small|small|medium|large|x-large|xx-large)$/i,
],
'font-style': [/^(?:normal|italic|oblique)$/i],
'font-weight': [/^(?:normal|bold|bolder|lighter|[1-9]00)$/i],
'text-decoration': [
/^(?:none|underline|line-through|overline)(?:\s+(?:underline|line-through|overline))*$/i,
],
},
},
transformTags: {
a: (tagName, attribs) => {
const target = attribs.target === '_blank' || attribs.target === '_self' ? attribs.target : undefined;
const { target: _target, rel: _rel, ...rest } = attribs;
return {
tagName,
attribs: target
? {
...rest,
target,
...(target === '_blank' ? { rel: 'noopener noreferrer nofollow' } : {}),
}
: rest,
};
},
font: (tagName, attribs) => ({
tagName,
attribs: {
...(attribs.color && safeFontColor(attribs.color) ? { color: attribs.color } : {}),
...(attribs.size && /^[1-7]$/.test(attribs.size) ? { size: attribs.size } : {}),
...(attribs.face && safeFontFace.test(attribs.face) ? { face: attribs.face } : {}),
...(attribs.style ? { style: attribs.style } : {}),
...(attribs.title ? { title: attribs.title } : {}),
},
}),
},
};
/**
* Canonicalizes Ref-compatible gateway notice markup on both writes and reads.
* Reads are purified again so pre-existing rows cannot execute active content.
*/
export const purifyGatewayNoticeHtml = (value: string | null | undefined): string => {
if (!value) return '';
return sanitizeHtml(value, options);
};