devsam/core2026
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: preserve Gateway release runtime context

Browse Source
This commit is contained in:
Hide_D
2026-08-08 15:57:38 +00:00
parent f4273709ae
commit 6a333cdf05
6 changed files with 57 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/release-controller/test/releaseController.test.ts
+26 -1
View File
@@ -73,7 +73,9 @@ const config: ReleaseControllerConfig = {
gatewayBasePath: '/gateway',
pollIntervalMs: 5,
readinessTimeoutMs: 10,
baseEnv: {},
baseEnv: {
REDIS_URL: 'redis://integration.invalid:6379/0',
},
};
afterEach(async () => {
@@ -127,6 +129,7 @@ it('does not forward release-controller PM2 identity to Gateway processes', () =
...config,
baseEnv: {
DATABASE_URL: 'postgresql://integration.invalid/sammo',
REDIS_URL: 'redis://integration.invalid:6379/0',
GATEWAY_ROLE: 'orchestrator',
args: 'daemon',
name: 'sammo:release-controller',
@@ -144,6 +147,15 @@ it('does not forward release-controller PM2 identity to Gateway processes', () =
}
});
it('rejects Gateway definitions before switching processes when Redis connection context is missing', () => {
expect(() =>
buildGatewayProcessDefinitions('/srv/sammo/release', {
...config,
baseEnv: {},
})
).toThrow('REDIS_URL is required to start Gateway processes.');
});
describe('GatewayReleaseController', () => {
it('builds, migrates, switches all gateway roles, verifies readiness, and publishes atomically', async () => {
const workspace = await createReleaseWorkspace();
@@ -239,6 +251,7 @@ describe('resolveReleaseControllerConfig', () => {
it('applies the configured gateway schema to the controller database URL', () => {
const resolved = resolveReleaseControllerConfig({
GATEWAY_DATABASE_URL: 'postgresql://user:pass@127.0.0.1:5432/sammo?schema=wrong',
REDIS_URL: 'redis://127.0.0.1:6379/0',
GATEWAY_DB_SCHEMA: 'gateway_release',
RELEASE_CONTROLLER_WORKSPACE_ROOT: '/srv/sammo/controller',
});
@@ -249,6 +262,7 @@ describe('resolveReleaseControllerConfig', () => {
it('removes PM2 metadata from the inherited controller environment', () => {
const resolved = resolveReleaseControllerConfig({
GATEWAY_DATABASE_URL: 'postgresql://user:pass@127.0.0.1:5432/sammo',
REDIS_URL: 'redis://127.0.0.1:6379/0',
RELEASE_CONTROLLER_WORKSPACE_ROOT: '/srv/sammo/controller',
args: 'daemon',
pm_id: '3',
@@ -258,6 +272,7 @@ describe('resolveReleaseControllerConfig', () => {
expect(resolved.baseEnv).toMatchObject({
GATEWAY_DATABASE_URL: 'postgresql://user:pass@127.0.0.1:5432/sammo',
REDIS_URL: 'redis://127.0.0.1:6379/0',
RELEASE_CONTROLLER_WORKSPACE_ROOT: '/srv/sammo/controller',
});
expect(resolved.baseEnv).not.toHaveProperty('pm_id');
@@ -265,6 +280,15 @@ describe('resolveReleaseControllerConfig', () => {
expect(resolved.baseEnv).not.toHaveProperty('name');
expect(resolved.baseEnv).not.toHaveProperty('axm_monitor');
});
it('rejects a controller environment that cannot start Redis-backed Gateway processes', () => {
expect(() =>
resolveReleaseControllerConfig({
GATEWAY_DATABASE_URL: 'postgresql://user:pass@127.0.0.1:5432/sammo',
RELEASE_CONTROLLER_WORKSPACE_ROOT: '/srv/sammo/controller',
})
).toThrow('REDIS_URL is required.');
});
});
describe('upgradeReleaseController', () => {
@@ -280,6 +304,7 @@ describe('upgradeReleaseController', () => {
});
expect(definition.env).toMatchObject({ DATABASE_URL: 'postgresql://integration.invalid/sammo' });
expect(definition.env).toHaveProperty('RELEASE_CONTROLLER_WORKSPACE_ROOT', config.workspaceRoot);
expect(definition.env).not.toHaveProperty('pm_id');
expect(definition.env).not.toHaveProperty('pm_exec_path');
expect(definition.env).not.toHaveProperty('name');