feat: add killturn to general meta and update related tests

- Introduced a new meta property `killturn` to the GeneralMeta interface.
- Implemented a function `readMetaNumber` to handle the retrieval of numeric values from meta.
- Updated the `mapGeneralRow` function to ensure `killturn` is required and properly handled.
- Modified various tests to include the `killturn` property in the general's meta data.
- Adjusted related action files to utilize the new GeneralMeta type for better type safety.
- Ensured backward compatibility by updating existing test cases across multiple scenarios.

packages/logic/test/actions/instant/nationStopWar.test.ts

@@ -85,7 +85,7 @@ const buildGeneral = (id: number, nationId: number, cityId: number, name = 'Test
         modifiers: {},
         meta: {},
     },
-    meta: {},
+    meta: { killturn: 24 },
 });
 
 const buildCity = (id: number, nationId: number): City => ({

packages/logic/test/actions/turn/nation.test.ts

@@ -50,7 +50,7 @@ const buildGeneral = (id: number, nationId: number, cityId: number, name = 'Test
         modifiers: {},
         meta: {},
     },
-    meta: {},
+    meta: { killturn: 24 },
 });
 
 const buildCity = (id: number, nationId: number): City => ({

packages/logic/test/actions/turn/nationMissing.test.ts

@@ -105,7 +105,7 @@ const buildGeneral = (id: number, nationId: number, cityId: number, name = 'Test
         modifiers: {},
         meta: {},
     },
-    meta: {},
+    meta: { killturn: 24 },
 });
 
 const buildCity = (id: number, nationId: number, name = `City${id}`): City => ({

packages/logic/test/crewType.test.ts

@@ -92,7 +92,7 @@ const buildGeneral = (): General => ({
         modifiers: {},
         meta: {},
     },
-    meta: {},
+    meta: { killturn: 24 },
 });
 
 const buildCities = (): City[] => [

packages/logic/test/dispatchWarAction.test.ts

@@ -48,7 +48,7 @@ const buildGeneral = (id: number, nationId: number, cityId: number): General =>
         modifiers: {},
         meta: {},
     },
-    meta: {},
+    meta: { killturn: 24 },
 });
 
 const buildCity = (id: number, nationId: number): City => ({

packages/logic/test/scenarios/diplomacy.test.ts

@@ -117,7 +117,7 @@ describe('Diplomacy Scenario', () => {
                 items: { horse: null, weapon: null, book: null, item: null },
             },
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const snapshot: WorldSnapshot = {

packages/logic/test/scenarios/domestic.test.ts

@@ -74,7 +74,7 @@ describe('Domestic Affairs Scenario', () => {
                 items: { horse: null, weapon: null, book: null, item: null },
             },
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const snapshot: WorldSnapshot = {
@@ -208,7 +208,7 @@ describe('Domestic Affairs Scenario', () => {
                 items: { horse: null, weapon: null, book: null, item: null },
             },
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const snapshot: WorldSnapshot = {

packages/logic/test/scenarios/general/che_NPC능동.test.ts

@@ -140,7 +140,7 @@ describe('che_NPC능동', () => {
             age: 20,
             npcState: 2, // NPC
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
 
@@ -195,7 +195,7 @@ describe('che_NPC능동', () => {
             age: 20,
             npcState: 0, // Human
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
 

packages/logic/test/scenarios/general/che_강행.test.ts

@@ -201,7 +201,7 @@ describe('che_강행', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation: Nation = {
             id: 1,
@@ -214,7 +214,7 @@ describe('che_강행', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
         world.snapshot.nations.push(nation);
@@ -285,7 +285,7 @@ describe('che_강행', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation: Nation = {
             id: 1,
@@ -298,7 +298,7 @@ describe('che_강행', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
         world.snapshot.nations.push(nation);
@@ -362,7 +362,7 @@ describe('che_강행', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const sub: General = {
@@ -391,7 +391,7 @@ describe('che_강행', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const nation: Nation = {

packages/logic/test/scenarios/general/che_귀환.test.ts

@@ -180,7 +180,7 @@ describe('che_귀환', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation: Nation = {
             id: 1,
@@ -193,7 +193,7 @@ describe('che_귀환', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
         world.snapshot.nations.push(nation);
@@ -252,7 +252,7 @@ describe('che_귀환', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: { officer_city: 103 },
+            meta: { killturn: 24, officer_city: 103 },
         };
         const nation: Nation = {
             id: 1,
@@ -265,7 +265,7 @@ describe('che_귀환', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
         world.snapshot.nations.push(nation);
@@ -318,7 +318,7 @@ describe('che_귀환', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation: Nation = {
             id: 1,
@@ -331,7 +331,7 @@ describe('che_귀환', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
         world.snapshot.nations.push(nation);
@@ -400,7 +400,7 @@ describe('che_귀환', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: { officer_city: 103 },
+            meta: { killturn: 24, officer_city: 103 },
         };
         const nation: Nation = {
             id: 1,
@@ -413,7 +413,7 @@ describe('che_귀환', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         world.snapshot.generals.push(general);
         world.snapshot.nations.push(nation);

packages/logic/test/scenarios/general/che_등용수락.test.ts

@@ -172,7 +172,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const recruiterGen: General = {
@@ -201,7 +201,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const nation2: Nation = {
@@ -215,7 +215,7 @@ describe('che_등용수락', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         world.snapshot.generals.push(neutralGen);
@@ -284,7 +284,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: { betray: 1 },
+            meta: { killturn: 24, betray: 1 },
         };
         const nation1: Nation = {
             id: 1,
@@ -297,7 +297,7 @@ describe('che_등용수락', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const recruiterGen: General = {
@@ -326,7 +326,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation2: Nation = {
             id: 2,
@@ -339,7 +339,7 @@ describe('che_등용수락', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         world.snapshot.generals.push(betrayer);
@@ -408,7 +408,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation1: Nation = {
             id: 1,
@@ -421,7 +421,7 @@ describe('che_등용수락', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         const recruiterGen: General = {
             id: 2,
@@ -444,7 +444,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation2: Nation = {
             id: 2,
@@ -457,7 +457,7 @@ describe('che_등용수락', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         world.snapshot.generals.push(monarch);
@@ -512,7 +512,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation1: Nation = {
             id: 1,
@@ -525,7 +525,7 @@ describe('che_등용수락', () => {
             power: 0,
             level: 1,
             typeCode: 'che_def',
-            meta: {},
+            meta: { killturn: 24 },
         };
         const recruiterGen: General = {
             id: 2,
@@ -548,7 +548,7 @@ describe('che_등용수락', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         world.snapshot.generals.push(general);

packages/logic/test/scenarios/general/che_이동.test.ts

@@ -92,7 +92,7 @@ describe('che_이동', () => {
             age: 20,
             npcState: 0,
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
         const nation: Nation = {
             id: 1,

packages/logic/test/scenarios/general_commands_new.test.ts

@@ -131,7 +131,7 @@ describe('General Commands New Scenario', () => {
                 items: { horse: null, weapon: null, book: null, item: null },
             },
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const snapshot: WorldSnapshot = {

packages/logic/test/scenarios/troops.test.ts

@@ -76,7 +76,7 @@ describe('Troop Management Scenario', () => {
                 items: { horse: null, weapon: null, book: null, item: null },
             },
             triggerState: { flags: {}, counters: {}, modifiers: {}, meta: {} },
-            meta: {},
+            meta: { killturn: 24 },
         };
 
         const snapshot: WorldSnapshot = {

packages/logic/test/specialActions.test.ts

@@ -60,7 +60,7 @@ const buildGeneral = (overrides: Partial<General> = {}): General => ({
         modifiers: {},
         meta: {},
     },
-    meta: {},
+    meta: { killturn: 24 },
     ...overrides,
 });
 

packages/logic/test/warAftermath.test.ts

@@ -123,7 +123,7 @@ const buildGeneral = (id: number, nationId: number, cityId: number): General =>
         modifiers: {},
         meta: {},
     },
-    meta: {},
+    meta: { killturn: 24 },
 });
 
 describe('war aftermath', () => {

packages/logic/test/warEngine.test.ts

@@ -153,6 +153,7 @@ const buildGeneral = (strength: number): General => ({
         meta: {},
     },
     meta: {
+        killturn: 24,
         dex1: 5000,
     },
 });