refactor: enforce package boundaries

app/game-api/src/battleSim/environment.ts

@@ -1,6 +1,6 @@
 import type { WorldStateRow } from '../context.js';
 import type { BattleSimJobPayload, BattleSimRequestPayload } from './types.js';
-import { loadUnitSetDefinitionByName } from './unitSetLoader.js';
+import { loadUnitSetDefinitionByName } from '@sammo-ts/game-engine/scenario/unitSetLoader.js';
 import { normalizeScenarioEffect, type ScenarioEffectKey, type WarEngineConfig } from '@sammo-ts/logic';
 import { asRecord } from '@sammo-ts/common';
 import type { UnitSetDefinition } from '@sammo-ts/logic';

app/game-api/src/battleSim/unitSetLoader.ts

@@ -1,39 +0,0 @@
-import fs from 'node:fs/promises';
-import path from 'node:path';
-
-import { parseUnitSetDefinition, type UnitSetDefinition } from '@sammo-ts/logic';
-
-import { resolveWorkspaceRoot } from '../paths.js';
-
-const REPO_ROOT = resolveWorkspaceRoot();
-const DEFAULT_UNIT_SET_ROOT = path.resolve(REPO_ROOT, 'resources', 'unitset');
-
-export interface UnitSetLoaderOptions {
-    unitSetRoot?: string;
-    filePrefix?: string;
-}
-
-const readJsonFile = async (filePath: string): Promise<unknown> => {
-    const raw = await fs.readFile(filePath, 'utf8');
-    return JSON.parse(raw) as unknown;
-};
-
-const resolveUnitSetRoot = (options?: UnitSetLoaderOptions): string => options?.unitSetRoot ?? DEFAULT_UNIT_SET_ROOT;
-
-export const resolveUnitSetDefinitionPath = (unitSetName: string, options?: UnitSetLoaderOptions): string => {
-    const prefix = options?.filePrefix ?? 'unitset_';
-    return path.resolve(resolveUnitSetRoot(options), `${prefix}${unitSetName}.json`);
-};
-
-export const loadUnitSetDefinition = async (unitSetPath: string): Promise<UnitSetDefinition> => {
-    const raw = await readJsonFile(unitSetPath);
-    return parseUnitSetDefinition(raw);
-};
-
-export const loadUnitSetDefinitionByName = async (
-    unitSetName: string,
-    options?: UnitSetLoaderOptions
-): Promise<UnitSetDefinition> => {
-    const unitSetPath = resolveUnitSetDefinitionPath(unitSetName, options);
-    return loadUnitSetDefinition(unitSetPath);
-};