feat: refactor utility functions for improved consistency and usability; consolidate parsing logic

app/game-api/src/config.ts

@@ -1,3 +1,5 @@
+import { parseNumberWithFallback } from '@sammo-ts/common';
+
 export interface GameApiConfig {
     host: string;
     port: number;
@@ -13,17 +15,6 @@ export interface GameApiConfig {
     flushChannel: string;
 }
 
-const parseNumber = (value: string | undefined, fallback: number, label: string): number => {
-    if (!value) {
-        return fallback;
-    }
-    const parsed = Number(value);
-    if (Number.isNaN(parsed)) {
-        throw new Error(`${label} must be a number.`);
-    }
-    return parsed;
-};
-
 export const resolveGameApiConfigFromEnv = (env: NodeJS.ProcessEnv = process.env): GameApiConfig => {
     const profile = env.PROFILE ?? env.SERVER_PROFILE ?? 'hwe';
     const scenario = env.SCENARIO ?? 'default';
@@ -36,19 +27,23 @@ export const resolveGameApiConfigFromEnv = (env: NodeJS.ProcessEnv = process.env
 
     return {
         host: env.GAME_API_HOST ?? '0.0.0.0',
-        port: parseNumber(env.GAME_API_PORT, 14000, 'GAME_API_PORT'),
+        port: parseNumberWithFallback(env.GAME_API_PORT, 14000, 'GAME_API_PORT'),
         trpcPath: env.TRPC_PATH ?? '/trpc',
         eventsPath: env.GAME_API_EVENTS_PATH ?? '/events',
         profile,
         scenario,
         profileName,
-        daemonRequestTimeoutMs: parseNumber(env.DAEMON_REQUEST_TIMEOUT_MS, 5000, 'DAEMON_REQUEST_TIMEOUT_MS'),
-        battleSimRequestTimeoutMs: parseNumber(
+        daemonRequestTimeoutMs: parseNumberWithFallback(env.DAEMON_REQUEST_TIMEOUT_MS, 5000, 'DAEMON_REQUEST_TIMEOUT_MS'),
+        battleSimRequestTimeoutMs: parseNumberWithFallback(
             env.BATTLE_SIM_REQUEST_TIMEOUT_MS,
             8000,
             'BATTLE_SIM_REQUEST_TIMEOUT_MS'
         ),
-        battleSimResultTtlSeconds: parseNumber(env.BATTLE_SIM_RESULT_TTL_SECONDS, 60, 'BATTLE_SIM_RESULT_TTL_SECONDS'),
+        battleSimResultTtlSeconds: parseNumberWithFallback(
+            env.BATTLE_SIM_RESULT_TTL_SECONDS,
+            60,
+            'BATTLE_SIM_RESULT_TTL_SECONDS'
+        ),
         gameTokenSecret: secret,
         flushChannel: `${gatewayPrefix}:flush`,
     };