feat: replace game schedules with logical ticks

2026-08-04 20:37:56 +09:00
parent 136acadd04
commit 5d9512ced7
69 changed files with 1616 additions and 519 deletions
@@ -0,0 +1,59 @@
+<?php
+
+namespace sammo;
+
+use PHPUnit\Framework\TestCase;
+
+final class GameClockBoundaryTest extends TestCase
+{
+    /** @dataProvider gameSchedulingFiles */
+    public function testGameSchedulingCodeDoesNotReadWallOrDatabaseClock(string $relativePath): void
+    {
+        $source = file_get_contents(__DIR__ . '/../' . $relativePath);
+        self::assertIsString($source);
+
+        foreach ([
+            '/TimeUtil::now(?:DateTimeImmutable)?\s*\(/',
+            '/new\s+\\\\?DateTime(?:Immutable)?\s*\(\s*\)/',
+            '/\bNOW\s*\(/i',
+            '/\bCURRENT_TIMESTAMP\b/i',
+            '/\bCURDATE\s*\(/i',
+        ] as $pattern) {
+            self::assertDoesNotMatchRegularExpression($pattern, $source, $relativePath);
+        }
+    }
+
+    public static function gameSchedulingFiles(): array
+    {
+        return array_map(static fn (string $path): array => [$path], [
+            'hwe/sammo/TurnExecutionHelper.php',
+            'hwe/sammo/Auction.php',
+            'hwe/sammo/AuctionBasicResource.php',
+            'hwe/sammo/AuctionUniqueItem.php',
+            'hwe/func_auction.php',
+            'hwe/func_tournament.php',
+            'hwe/c_tournament.php',
+            'hwe/sammo/AbsFromUserPool.php',
+            'hwe/sammo/GeneralPool/RandomNameGeneral.php',
+            'hwe/sammo/API/General/DieOnPrestart.php',
+        ]);
+    }
+
+    public function testTickSchemaDoesNotUseDatabaseDefaultsForGameSchedules(): void
+    {
+        $schema = file_get_contents(__DIR__ . '/../hwe/sql/schema.sql');
+        self::assertIsString($schema);
+        foreach ([
+            '`turntime` BIGINT',
+            '`recent_war` BIGINT',
+            '`last_refresh` BIGINT',
+            '`time` BIGINT',
+            '`valid_until` BIGINT',
+            '`reserved_until` BIGINT',
+            '`open_tick` BIGINT',
+            '`close_tick` BIGINT',
+        ] as $expected) {
+            self::assertStringContainsString($expected, $schema);
+        }
+    }
+}
@@ -0,0 +1,99 @@
+<?php
+
+namespace sammo;
+
+use PHPUnit\Framework\TestCase;
+
+require_once __DIR__ . '/../src/sammo/GameClock.php';
+
+final class GameClockTest extends TestCase
+{
+    /** @dataProvider supportedTurnTerms */
+    public function testEachSupportedTurnTermHasIntegerTicksPerSecond(int $turnTerm, int $ticksPerSecond): void
+    {
+        $base = new \DateTimeImmutable('2026-08-03 00:00:00.000000');
+        $clock = new GameClock($base, $turnTerm, 0, GameClock::MODE_MANUAL, $base);
+
+        self::assertSame($ticksPerSecond, $clock->ticksPerSecond());
+        self::assertSame(GameClock::TICKS_PER_TURN, $clock->ticksFromMinutes($turnTerm));
+    }
+
+    public static function supportedTurnTerms(): array
+    {
+        return [
+            '1 minute' => [1, 600_000],
+            '2 minutes' => [2, 300_000],
+            '5 minutes' => [5, 120_000],
+            '10 minutes' => [10, 60_000],
+            '60 minutes' => [60, 10_000],
+            '120 minutes' => [120, 5_000],
+        ];
+    }
+
+    public function testTickFormulaAndDisplayProjectionRoundTrip(): void
+    {
+        $base = new \DateTimeImmutable('2026-08-03 12:34:56.000000');
+        $clock = new GameClock($base, 60, 0, GameClock::MODE_MANUAL, $base);
+        $tick = GameClock::TICKS_PER_TURN * 7 + 12_345;
+
+        self::assertSame(['turn' => 7, 'subTick' => 12_345], $clock->splitTick($tick));
+        self::assertSame($tick, $clock->dateTimeToTick($clock->tickToDateTime($tick)));
+        self::assertSame('2026-08-03 19:34:57.234500', $clock->formatTick($tick, true));
+    }
+
+    public function testManualModeDoesNotReadWallClock(): void
+    {
+        $base = new \DateTimeImmutable('2026-08-03 00:00:00.000000');
+        $wallRead = false;
+        $clock = new GameClock(
+            $base,
+            10,
+            123_456,
+            GameClock::MODE_MANUAL,
+            $base,
+            function () use (&$wallRead): \DateTimeImmutable {
+                $wallRead = true;
+                return new \DateTimeImmutable('2099-01-01 00:00:00.000000');
+            },
+        );
+
+        self::assertSame(123_456, $clock->nowTick());
+        self::assertFalse($wallRead);
+    }
+
+    public function testNegativeTickProjectionAndBaseRecalculation(): void
+    {
+        $projected = new \DateTimeImmutable('2026-08-03 12:00:00.123400');
+        $tick = -36_001_234;
+        $base = GameClock::baseTimeForProjection($projected, $tick, 60);
+        $clock = new GameClock($base, 60, $tick, GameClock::MODE_MANUAL, $projected);
+
+        self::assertSame($tick, $clock->dateTimeToTick($clock->tickToDateTime($tick)));
+        self::assertSame('2026-08-03 12:00:00.123400', $clock->formatTick($tick, true));
+        self::assertSame(['turn' => -2, 'subTick' => 35_998_766], $clock->splitTick($tick));
+    }
+
+    public function testRealtimeModeAdvancesFromAnchorWithoutDatabaseNow(): void
+    {
+        $base = new \DateTimeImmutable('2026-08-03 00:00:00.000000');
+        $wallAnchor = new \DateTimeImmutable('2026-08-03 10:00:00.000000');
+        $clock = new GameClock(
+            $base,
+            120,
+            100,
+            GameClock::MODE_REALTIME,
+            $wallAnchor,
+            fn (): \DateTimeImmutable => new \DateTimeImmutable('2026-08-03 10:00:01.500000'),
+        );
+
+        self::assertSame(7_600, $clock->nowTick());
+    }
+
+    public function testTickArithmeticRejectsValuesThatJavaScriptCannotRepresentExactly(): void
+    {
+        self::assertSame(GameClock::MAX_SAFE_TICK, GameClock::addTicks(GameClock::MAX_SAFE_TICK - 1, 1));
+
+        $this->expectException(\OverflowException::class);
+        GameClock::addTicks(GameClock::MAX_SAFE_TICK, 1);
+    }
+}